Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UnaliasCollectionMethodsRector #291

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Add UnaliasCollectionMethodsRector #291

merged 1 commit into from
Jan 11, 2025

Conversation

spawnia
Copy link
Contributor

@spawnia spawnia commented Jan 10, 2025

No description provided.

@GeniJaho GeniJaho merged commit 03c1396 into driftingly:main Jan 11, 2025
5 checks passed
@GeniJaho
Copy link
Collaborator

Thanks for the PR @spawnia.
While the same can be achieved with the configurable rule RenameMethodRector, it would be difficult to include the LARAVEL_COLLECTION set and be able to skip a particular configured rule. So a specific rule like this makes sense in this case 👍.

@spawnia spawnia deleted the unalias-collection-methods branch January 13, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spawnia @GeniJaho